Null-MC / Shrimple

A simple Minecraft Java shader that attempts to maintain the vanilla aesthetic while adding optional shadows & colored lighting.
Other
117 stars 6 forks source link

No custom emissive textures? #81

Open HellFox69 opened 2 months ago

HellFox69 commented 2 months ago

Hello. I have an issue with emissive textures. I tried to make them work in many ways, but without any success. I have installed Indium and Continuity to make them work with Iris, however Shrimple Shaders just doesn't work, even when I changed the emission type to LabPBR etc. Emissive textures work well with other shaders. Is there any way to somehow enable them? I really like these shaders and would like to stick with them, as they are very nice looking and performance impact is not as high as with other ray traced shaders. I have attached some photos of what I meant to do. continuum seus ptgi e12 sildurs vibrant solas 2 0 beta shrimple

HellFox69 commented 2 months ago

Ok, so turns out emissive textures work, but only when I select the "Shadows" or "Vanilla" preset. "RTX" and "Colored lights" still doesn't work.

null511 commented 2 months ago

emissive textures should always work, you probably just need to increase the strength (under emission settings) the shadows/colored lights/RTX profiles have lighting ~6x brighter

null511 commented 2 months ago

by default they are tuned low to match vanilla, since (all the fancy things aside) shrimple was intended to be vanilla-like.

SJK9906 commented 2 months ago

i some problem with emissive texture on tools, block and other

null511 commented 2 months ago

What resource pack are you using, and are you sure it has LabPBR emission and not optifine emission?

HellFox69 commented 2 months ago

emissive textures should always work, you probably just need to increase the strength (under emission settings) the shadows/colored lights/RTX profiles have lighting ~6x brighter

Still nothing. I tweaked the brightness to 8000% and my terracotta blocks' emissive textures still don't glow. The only way to make them work is to go "Lighting -> Mode: Vanilla/Basic". The FloodFill and Ray Traced modes make them behave like there is no emissive textures in my resource pack. brightness 8k

null511 commented 2 months ago

What resource pack are you using, and are you sure it has LabPBR emission and not optifine emission?

And to be clear, you do mean "how bright the surface looks" and not "casting light onto nearby objects", only the former is done by texture emission.

HellFox69 commented 1 month ago

I managed to make it work by just updating the specular textures of the blocks I wanted to glow. However, blocks that were using the "Integrated" profile of emission started to be very dark (Magma block for example). Do I need to make speculars for them too, or can I somehow enable emission from these blocks? And second question, is it possible to add colored lights to the blocks from my resource pack? I got it to work with SEUS PTGI by modifying some lines of code, but I had no luck here, 2024-05-11_09 17 12