search

NullCGT / SpliceHack

An in-progress nethack variant based on version 3.7. An attempt to build a "kitchen sink" style variant that is easy to pick up and play.
Other
29 stars 12 forks source link

Just the fixes #222

Closed RojjaCebolla closed 2 years ago

RojjaCebolla commented 2 years ago

Two of the fixes from #205 already got pushed to 1.0, which itself got merged into 1.1. So those two commits can be rebased out of the PR, and these two commits can be peeled out to be ready for a server version bump.

And that simplifies the ridicihuge PR a bit!

NullCGT commented 2 years ago

I don't think any rebasing is necessary in this scenario, and rebasing should be avoided unless absolutely one hundred percent necessary. Rebasing is destructive to the history of a repository, and very dangerous.

RojjaCebolla commented 2 years ago

@NullCGT Ah, ok - thought it might be alright for a not-merged PR. But i'll not do that, then!