search

NullEnt1ty / gmod-wiki-scraper

Extract GLua API documentation from the new Garry's Mod wiki
https://www.npmjs.com/package/gmod-wiki-scraper
MIT License
9 stars 1 forks source link

Parse source links #24

Closed brandonsturgeon closed 2 months ago

brandonsturgeon commented 1 year ago

This parses the "View Source" links on pages that have it. It handles single-line and multi-line sources.

Examples in output:

    "source": {
      "file": "lua/includes/util.lua",
      "lineStart": 177,
      "lineEnd": 219
    }
    "source": {
      "file": "lua/menu/background.lua",
      "lineStart": 77
    }

And is absent for functions that don't have it.

NullEnt1ty commented 1 year ago

Thanks for your contribution! The code looks good at first glance, I'm gonna test it in the coming days (probably on wednesday).

brandonsturgeon commented 2 months ago

My apologies, I have no idea how I forgot about this PR for so long!

I've addressed your review comments and verified that scraping works 👍

NullEnt1ty commented 2 months ago

My apologies, I have no idea how I forgot about this PR for so long!

No worries. I totally forgot about this PR as well 😅.

The changes look good to me. Thanks for your contribution! I will try to publish a new version later this day.