search

NullHypothesis / exitmap

A fast and modular scanner for Tor exit relays. The canonical repository (including issue tracker) is at https://gitlab.torproject.org/tpo/network-health/exitmap
https://www.cs.kau.se/philwint/spoiled_onions/
GNU General Public License v3.0
454 stars 107 forks source link

Test Re-Organization #32

Closed frankcash closed 8 years ago

frankcash commented 9 years ago

Moves the tests from src/ to test/. They were starting to clutter up src/.

I also extended test coverage by 3% :high_brightness:! I simply added coverage for some None type returns I didn't account for originally.

Works on https://github.com/NullHypothesis/exitmap/issues/22

NullHypothesis commented 9 years ago

Thanks for the pull request, Frank. Could you please also change the test code in .travis.yml?

frankcash commented 9 years ago

Sorry about that, will do!

frankcash commented 9 years ago

Looks like it passes all version except for 2.6. It appears assertIsNone is 2.7+

I have no problem reverting my code. But Python 2.6 is also EOL'd.

With the 2.6.9 release, and five years after its first release, the Python 2.6 series is now officially retired. All official maintenance for Python 2.6, including security patches, has ended. For ongoing maintenance releases, please see the Python 2.7 series. The NEWS file lists every change in each alpha, beta, release candidate, and final release of Python 2.6.

I should've ran my local version against 2.6 before pushing this, sorry about that. But I guess now is a good time for the discussion too.

NullHypothesis commented 8 years ago

(Sorry for the delay. Had to work on the weekend and I'm catching up now.)

I think it's sane to not support Python 2.6 anymore. Would you mind updating .travis.yml and removing the tests for 2.6?

frankcash commented 8 years ago

I updated the .travis.yml, don't think there is anything else that needs to be changed

NullHypothesis commented 8 years ago

Looks good, thanks for your help!

frankcash commented 8 years ago

Glad I could help :smile: