search

NullHypothesis / exitmap

A fast and modular scanner for Tor exit relays. The canonical repository (including issue tracker) is at https://gitlab.torproject.org/tpo/network-health/exitmap
https://www.cs.kau.se/philwint/spoiled_onions/
GNU General Public License v3.0
454 stars 107 forks source link

Code Issue in run_tests.py #57

Closed vasiqmz closed 7 years ago

vasiqmz commented 7 years ago

Hey Philip,

I have described the error in run_tests.py commit. Kindly review it.

Thank you,

Vasiq Mz

NullHypothesis commented 7 years ago

Thanks, Vasiq! In general, the changes look good to me, but would you mind cleaning up the git log message a bit? c5ae5ce661e58267db6f18b5719266fa60b64d90 should have a more descriptive overview, for example "Fix broken test." instead of just "Description:". 04fbca3e1f799e1a407dd1212a0fd641934dea2d should have a shorter overview. See http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html for an example of a good commit message.

vasiqmz commented 7 years ago

Thanks, Philipp. I have made the changes in the commit. Thanks for the tips on Commit message.

NullHypothesis commented 7 years ago

Looks good to me, thanks!