search

NullNameException / camera-points

Save and load camera positions
BSD 2-Clause "Simplified" License
3 stars 2 forks source link

Key remapping plugin compatibility & focus check #3

Closed KogasaPls closed 3 years ago

KogasaPls commented 3 years ago

I recycled some code from the Key Remapping plugin to do two things:

1) Check for the chatbox listener before setting the camera. For example, when typing in the World Map search box, the listener will be inactive and the plugin will no longer set the camera.

2) Add a "Key Remapping plugin enabled" setting. When checked, the plugin will not set the camera while typing in the chatbox. When unchecked, the plugin works as before except with the change 1).

I'm not sure if there's a way to directly check if a plugin is enabled, but if so that would be better than adding a toggle.

NullNameException commented 3 years ago

Looks good and seems to work for what I tested. I wanted to add that as well but never got around to do it so thank you!

NullNameException commented 3 years ago

I just noticed that you added this on the master branch which has some features that weren't allowed so I created the camera-zoom branch with only the allowed features to create a pull request for the plugin-hub. Sorry for the confusion! I'll update it soon.