search

NullVoxPopuli / ember-addon-migrator

ember addon v1 to v2 migrator
19 stars 4 forks source link

Fix blueprint for scoped package names #52

Closed simonihmig closed 1 year ago

simonihmig commented 1 year ago

When the addon has a scoped package name, then ember-cli will turn that into a somehow dasherized version of it as the addon location, which then did not match the location we were expecting.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 4076d37bf42aa8ae66663da237e7f6c4544fe825

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | ember-addon-migrator | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

simonihmig commented 1 year ago

I didn't look int your testing setup yet, can add a test if you like and that's feasible?

NullVoxPopuli commented 1 year ago

can add a test if you like and that's feasible?

renaming an existing addon, maybe base-js-v1-addon to have a scope would probably be sufficient! thank you!!

simonihmig commented 1 year ago

renaming an existing addon, maybe base-js-v1-addon to have a scope would probably be sufficient!

Just pushed that!

simonihmig commented 1 year ago

Had to revert the scoped name of the test fixture from @NullVoxPopuli/* to @some/*. Took me a while to figure out why this was not working (besides other fixes in the last commit).

Seems we have a bug in our v2 blueprint: it added @null-vox-populi/* as a dependency to the test-app. Seems some dasherize call is messing this up there. Only came up here by coincidence, as any all-lowercase scope would not trigger that! 😅