Remove any js/ts duplicates as the result of copying from dummy app

NullVoxPopuli / ember-addon-migrator

ember addon v1 to v2 migrator

19 stars 4 forks source link

Remove any js/ts duplicates as the result of copying from dummy app #86

Closed simonihmig closed 1 year ago

simonihmig commented 1 year ago

When the dummy app has e.g. a app.js file, and the app blueprint (with --typescript) has an app.ts, after copying the files from the dummy app you would end up with duplicates of app.js vs. app.ts, which is bad. As the .js file coming from the dummy app could contain meaningful code that is not included in the fresh boilerplate, it should take precedence.

stackblitz[bot] commented 1 year ago

Run & review this pull request in StackBlitz Codeflow.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 79faf1b93bcc48d8d4730fcae58b1e006ef386eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

simonihmig commented 1 year ago

~Note to myself: the failing test will hopefully get fixed when we merge #84 and rebase...~

Passing now! :tada: