Closed MichalBryxi closed 1 year ago
Run & review this pull request in StackBlitz Codeflow.
Latest commit: c7208ec5d660f2c2ef9b44692f5c7e3c4740c6f4
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Initial implementation to kickstart discussion. I have no clue how to make some tests for this to make sure it does the correct job?
Updated all the pieces. The snapshot diff does not lookg horrible (generated via pnpm test
), but it contains onlyu changes in package.json
. What am I doing wrong? 🤔
it looks like diff
only shows the diff of files tracked by git, https://github.com/NullVoxPopuli/ember-apply/blob/main/ember-apply/src/test-utils.js#L76
so it's possible a different commands needs to be ran to include tracked files (maybe a git add .
needs to run first? (since you're adding new files)
Ok so for some reason the CI for volta is broken on this branch. I patched it to have CI green (see separate commit), but IDK if you want that in here or as separate PR?
its fine, thank you!!!