NullVoxPopuli / ember-apply

Automatic integration and configuration from the EmberJS community
https://ember-apply.pages.dev
MIT License
38 stars 9 forks source link

feat: tailwind-webpack initial implementation #493

Closed MichalBryxi closed 1 year ago

MichalBryxi commented 1 year ago
stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: c7208ec5d660f2c2ef9b44692f5c7e3c4740c6f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------------------- | ----- | | @ember-apply/tailwind-webpack | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

MichalBryxi commented 1 year ago

Initial implementation to kickstart discussion. I have no clue how to make some tests for this to make sure it does the correct job?

MichalBryxi commented 1 year ago

Updated all the pieces. The snapshot diff does not lookg horrible (generated via pnpm test), but it contains onlyu changes in package.json. What am I doing wrong? 🤔

NullVoxPopuli commented 1 year ago

it looks like diff only shows the diff of files tracked by git, https://github.com/NullVoxPopuli/ember-apply/blob/main/ember-apply/src/test-utils.js#L76

so it's possible a different commands needs to be ran to include tracked files (maybe a git add . needs to run first? (since you're adding new files)

MichalBryxi commented 1 year ago

Ok so for some reason the CI for volta is broken on this branch. I patched it to have CI green (see separate commit), but IDK if you want that in here or as separate PR?

NullVoxPopuli commented 1 year ago

its fine, thank you!!!