NullVoxPopuli / ember-apply

Automatic integration and configuration from the EmberJS community
https://ember-apply.pages.dev
MIT License
38 stars 9 forks source link

Fix some issues with the `typescript` automation for v1 addons #530

Closed Windvis closed 4 months ago

Windvis commented 10 months ago

Not everything is fully automated, but it doesn't throw any errors anymore and the console messages should provide enough guidance to finish the work manually.

closes #527

stackblitz[bot] commented 10 months ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

changeset-bot[bot] commented 10 months ago

⚠️ No Changeset found

Latest commit: 1b706a62e9e01e755faee6cdf5eb1872ed79d83e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Windvis commented 10 months ago

I tried adding a changeset but it only seems to allow major bumps? I'm probably missing something.

image

NullVoxPopuli commented 10 months ago

I tried adding a changeset but it only seems to allow major bumps?

don't worry about that, changeset is for the maintainers to manage <3


This PR is looking great!! thanks a ton for working on it!!

NullVoxPopuli commented 9 months ago

any chance you can rebase? CI is fixed :sweat_smile:

Windvis commented 9 months ago

I probably won't have time for anything besides a rebase though 😞. So if you think it is useful in its current state I'll try to rebase ASAP.