Open NullVoxPopuli opened 2 years ago
Should https://github.com/NullVoxPopuli/ember-resources/blob/main/ember-resources/src/core/class-based/manager.ts#L3 use @glimmer/destroyable?
yeah, I think all the @ember/*
imports have glimmer counterparts like that.
The only thing I'm uncertain about is assert
from @ember/debug
.
I like that consuming apps remove those from production builds -- but idk if glimmer has an equivalent, and then if glimmer projects also remove those from production builds.
Since all the framework dependencies in this library are actually re-exports of glimmer packages, it should be fairly straightforward (behaviorally) to support both ember and glimmer.
A tricky part may be (uncertainty) typescript support for all of ember/glimmer/glint simultaneously (maybe). Glint depends on glimmer dependencies as well, so maybe this is a non issue.
Here is a sample glimmer app that could be copied for making a test app: https://github.com/knownasilya/logux-poc