search

NullVoxPopuli / qunit-assertions-extra

Collection of helpful assertions for use with qunit
MIT License
19 stars 3 forks source link

Update installation instructions #58

Closed rohitpaulk closed 1 year ago

rohitpaulk commented 1 year ago

👋

After upgrading from 0.8.5 to 1.x, I ran into errors saying assert.contains not a function. Checked the changes for 1.x, and looks like the installation method has changed:

Screenshot 2023-05-07 at 16 38 06

Using setup as mentioned above fixed the errors, I'm not sure if the previous behaviour was supposed to work though.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: dfa756a33a6188b3cea07928615ead2e2221e72e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rohitpaulk commented 1 year ago

Not sure if this needs a changeset since it is just a README update, let me know if it does and I can add one though!

NullVoxPopuli commented 1 year ago

naw, we're good -- thanks for submitting this!