Replacing panics with errors improves the usability of the crate

Nullus157 / async-compression

Adaptors between compression crates and Rust's async IO types

https://docs.rs/async-compression

Apache License 2.0

386 stars 74 forks source link

Replacing panics with errors improves the usability of the crate #255

Closed garypen closed 9 months ago

garypen commented 9 months ago

I hope you'll consider this PR for inclusion in a patch release.

This PR replaces panics with errors. This is important when the crate is being used in, for example, a long running server process where handling an error is preferred to a panic.

This should help with issues such as: #188 or #246

NobodyXu commented 9 months ago

Pinging @robjtede

NobodyXu commented 9 months ago

I will merge this PR now, if there's any problem with it we can always open another PR later.

Geal commented 8 months ago

@NobodyXu will there be a release soon with this fix?

NobodyXu commented 8 months ago

yes, I can open a patch release tomorrow