search

Nullus157 / bs58-rs

Another Rust Base58 codec implementation
Apache License 2.0
78 stars 24 forks source link

Support no_std #33

Closed koushiro closed 5 years ago

koushiro commented 5 years ago

Signed-off-by: koushiro koushiro.cqx@gmail.com

What I have changed

Nemo157 commented 5 years ago

Awesome, thanks a lot for this. I want to make one more release of the 0.2 versions to get the error deprecation then I'll merge this and start on a 0.3 version including it.

koushiro commented 5 years ago

@Nemo157 Maybe we can upgrade minimum supported rustc version (how about 1.31) on version 0.3.

Nemo157 commented 5 years ago

Yep, my plan is to remove the minimum version policy and only support latest stable. So, if you feel like switching to edition 2018 for the easier way to support no_std I'd be for that.

I think it would also be good to split off an alloc feature, I think it should be possible to support the APIs that take in a pre-allocated output without it.

koushiro commented 5 years ago

Awesome, that sounds good

koushiro commented 5 years ago

BTW, I think adding format check is a good choice in new version.

Nemo157 commented 5 years ago

I hope you don't mind I took the liberty of cherry-picking your changes and splitting them across #35 and #36, moving the tests was very helpful for migrating the code to a modern clippy. Again, thanks a lot for this!