Nullus157 / bs58-rs

Another Rust Base58 codec implementation
Apache License 2.0
75 stars 24 forks source link

Add support for CB58 #82

Closed ghost closed 2 years ago

ghost commented 2 years ago

This PR adds support for CB58 encoding via a feature flag.

While I understand this is very specific functionality, there is other specific functionality in the crate already and this feature flag wouldn't add any overhead to users that do not make use of this feature.

Let me know if you require more changes. I have added doctests to the functions to encode/decode with the cb58 checksum. Some elements (like the error variants) are now exposed when the feature is enabled, mirroring the check feature functionality.

Nemo157 commented 2 years ago

Thanks for the PR, and sorry about the delay.

I've rebased this and done some minor fixes for other changes that were merged in #88, which should merge soon.