NumEconCopenhagen / Projects_2024_Emma-Anna-Oscar

projects-2024-emma-anna-oscar created by GitHub Classroom
MIT License
0 stars 0 forks source link

Peer feedback from Andreas_and_Mangus on the data project #6

Closed AndreasTroglauer closed 4 months ago

AndreasTroglauer commented 5 months ago

Firstly, a very nice project

  1. The most elegant solution in the project was: (explain what and why)
    • We really like the text in the assignment. it is clearly explained what you are investigating, and the structure is very clear.
  2. The hardest section of code in the project to understand was: (explain what)
    • We had trouble knowing what .py files that needed to be loaded. in your read.me file, you have only stated that the project can be seen by running the notebook, yet in the notebook you draw from a .py file - så maybe update the readme file :) but reading the notebook, it is clear which py files who needs to be runned :)
  3. This part of the project could be better documented: (explain what)
    • overall the projects are well documented, but perhabs you could explain the figure in 1.2, what it is showing.
  4. An idea for an improvement/clarification could be: (explain what and why)
    • I have 1 small things who I think could be improved:
  5. The read.me file, state which files who should be loaded, so the notebook can be read by one click
  6. An idea for an extension could be: (explain what and why)
    • I really think you covered everything, very nice to read :)