NumEconCopenhagen / projects-2019-mk

projects-2019-mk created by GitHub Classroom
MIT License
0 stars 4 forks source link

Peer feedback on the modelproject #5

Open MathiasNymand opened 5 years ago

MathiasNymand commented 5 years ago

Overall a very good project once it works.

The best part of the project:

The way you use bounds when you solve equations an thereby keep restricting the portfolio weights to always sum to one in the case where you find the capital market line. Your plots are also very good.

The hardest part of the project to understand was:

The code behind sci.splev. As I understand it, it just evaluates the functions differentials, but you should explain that better. Generally more docstrings would be useful for the advanced parts.

Idea for improvement/clarification:

You have quite a few spelling errors in the readme file. This will make it easier to understand (I hope I have not made many mistakes here). Also, you should add somewhere a link to the module you call yf as it is nor default in Anaconda.

Idea for an extension:

Use Sympy to solve some equations and algebra.