NumEconCopenhagen / projects-2023-python

projects-2023-python created by GitHub Classroom
MIT License
0 stars 0 forks source link

Peerfeedback #1

Open tkn981 opened 1 year ago

tkn981 commented 1 year ago

Hi Group Python

The most elegant solution in the project was: For Question 1 the decision of using the dataframe option/function where you clarify which situations where the alpha and sigma variables have different outputs. I find that quite nice. Furthermore i do like, how the results for the estimated optimum of alpha and sigma is presented before plotted in Question 4. Overall i think the assignment in general is quite elegant with the structure of the coding. All tasks are clearly arranged and the approach is similar in terms of structure, which makes for an easy reading experience.

The hardest section of code in the project to understand was: For me the hardest section of code to understand in the notebook file must be arranging of the table in question 1 (e). The rest of the notebook is straightforward and easy to understand. For the pyfile, i think that there are several section of coding which is hard to understand, and hard to understand how to find that particular coding without the use of chatbots and other coding tools.

This part of the project could be better documented: To be honest i think you are presenting what must be presented, and i don't think it is necessary to further document because it would make the notebook more confusing. However if you should further document i would do it in Question 4. Or maybe in Question 3, when defining the continously model.

An idea for an extension could be: One could further comment on the level of women's wages and the rationale for working at home. Or any explanations as to why the discrepancy between your results and the "theoretical" model is so large. I think it is a good assignment with lots of introductory text and round-up of questions.

mcz724 commented 1 year ago

This is feedback from: emil-freddy