NumEconCopenhagen / projects-2023-python

projects-2023-python created by GitHub Classroom
MIT License
0 stars 0 forks source link

Feedback on Dataproject. #3

Open hln311 opened 1 year ago

hln311 commented 1 year ago

Overall i find that the code seems to be well-commented and organized. As a reader I can follow what you are doing and why. The code is simple as efficient, which makes it easy to understand, i especially like how you are commenting every important step of the code.

The only comments i have to the code is to maybe us the list comprehension instead of using a for loop to create a new list. It's a shorter and more efficient way to create a new list. Likewise you can you the sum() function instead in the later part of your code.

Additionally I would suggest to make the project even better is to maybe include some more variables. Maybe look at the energy demand for some other industries and see if they have a different energy demand and elasticity.

Overall i think this is a good project!