NumEconCopenhagen / projects-2023-shashi-buhle

projects-2023-shashi-buhle created by GitHub Classroom
MIT License
0 stars 0 forks source link

Feedback #1

Open qlv164 opened 1 year ago

qlv164 commented 1 year ago
  1. The most elegant solution in the project was: the creation of the graph in the first exercise is very interesting, since it helps to understand the reationship between alpha, sigma and the solution, even when it was not necessary. Also, it shows a good understanding of the graph command and the 3D feature, as well as the colors feature. The explanations at the beginning of each exercise is a plus because it makes so much easier to understand the code. I think it is very good that in the code for solve_wF_vec, you include a possibility to use the discrete or continuous model.
  2. The hardest section of code in the project to understand was: Nothing, it was very well commented!!!
  3. This part of the project could be better documented: The table in the first exercise can be presented better, maybe changing the format of the numbers and without a title in the middle of it.
  4. An idea for an improvement/clarification could be: It is important to check that the comments in the code corresponds to what thay are going to do (for example exercise 2 and 3 in the notebook share the same comments, even when in exercise 2 you use discrete solution and in exercise 3 you use continuous solution).
  5. An idea for an extension could be: Nothing, it is very complete!!!