NumEconCopenhagen / projects-2023-shashi-buhle

projects-2023-shashi-buhle created by GitHub Classroom
MIT License
0 stars 0 forks source link

Feedback for Data project #5

Open Oliverhoutved opened 1 year ago

Oliverhoutved commented 1 year ago

The most elegant solution in the project was: (explain what and why): Generally I think your code is elegant and looks good The hardest section of code in the project to understand was: (explain what): Nothing about the code is really difficult to understand as you have documented what you have done pretty thoroughly throughout the code This part of the project could be better documented: (explain what): I think the amount of data used for the project is too large, as it could be confusing as to why you would use that much An idea for an improvement/clarification could be: (explain what and why): Your code is quite long, and combined with the large dataset it required more computer power than necessary. For example you can create a loop through to iterate through the DataFrames and convert the 'year' column to an integer data type. This would removerepetitive code and make the script more concise.

An idea for an extension could be: (explain what and why): It is an interesting subject and your analysis could be improved by using more complicit calculations such as regressions