NumEconCopenhagen / projects-2023-teamssb

projects-2023-teamssb created by GitHub Classroom
MIT License
0 stars 0 forks source link

Peer Feedback #2

Open wvf224 opened 1 year ago

wvf224 commented 1 year ago
  1. The most elegant solution in the project was: I think the most elegant solution was to question 4. Your answer is very thorough and your approach to the question is well described. Maybe the 3d plot (Figure 5) is a bit overkill, but it does look nice.

  2. The hardest section of code in the project to understand was: Overall, the code seems relatively easy to understand. You could perhaps state a bit more explicitly what the differences are between HSM.py and NHSM.py in the NHSM.py file. It would increase the readability.

  3. This part of the project could be better documented: In question 5 it could be an idea to explain $\nu$ and $\eta$ a bit more, since this is what is changed compared to the original utility function.

  4. An idea for an improvement/clarification could be: You could maybe add some comments to your functions e.g. solve_wF_vec, run_regression, estimate, est etc.

  5. An idea for an extension could be: Not quite sure. The project is in general very good, and with code that is straight forward to run.