search

NumEconCopenhagen / projects-2023-teamssb

projects-2023-teamssb created by GitHub Classroom
MIT License
0 stars 0 forks source link

Peerfeedback modelproject #4

Open tkn981 opened 1 year ago

tkn981 commented 1 year ago

Hi Teamssb

Feedback to the model project:

I think the most elegant element of the project is the simplicity when coding and kind of surplus when expressing the different kind of models. Hiding all the code in the pyfiles makes the notebook easily accessible.

I think the hardest section of code in the project to understand was plot_widget function. Overall very good coding, sticking to the same principles with lambda functions.

The pyfile could be slightly more unpacked information vise. I know you shortly describes what's going to happen at the top. By some explanation could be done as the code is written.

The project is bit long. Well done.

I like the plots and the widgets. If it is possible more visual would be very nice.

E-Kjems commented 1 year ago

  1. The most elegant solution in the project was: The implementation of the Brent-Method for numerical solution.

  2. The hardest section of code in the project to understand was: The implementation of microfoundations and the quantity/quality tradeoff. Additional comments or explanations would enhance comprehension.

  3. This part of the project could be better documented: The section explaining the Brent-Method could benefit from clearer documentation. Step-by-step explanations.

  4. An idea for improvement/clarification could be: You could further describe the plot

  5. An idea for an extension could be: Introducing interactive visualizations or simulations to demonstrate population dynamics and parameter effects.