NumEconCopenhagen / projects-2024-jonas-mads

projects-2024-jonas-mads created by GitHub Classroom
MIT License
0 stars 0 forks source link

Peer feedback #1

Open PetraCentis opened 5 months ago

PetraCentis commented 5 months ago

The most elegant solution in the project was: (explain what and why) I think that the code for the second question was really straightforward and easy to understand, the fact that it was really short makes it nice and clear. Also the use of root_scalar in question 3 was pretty clever.

The hardest section of code in the project to understand was: (explain what) I think that to make the code more clear and easy to read you should use more your ExchangeEconomy.py file, in this way by just recalling the code from there and just displaying the solutions would make the solution more straightforward to see.

This part of the project could be better documented: (explain what) Not really sure, maybe just commenting the results and what you get in every question would make the project be more easy to read.

An idea for an improvement/clarification could be: (explain what and why) It would be nice if you added some markdown cells to separate the different tasks and maybe explained what the next code was trying to do, just so to link the code with the theory. I find that markdown cells make the structure more clear, but this is just to make the code look nice.

An idea for an extension could be: (explain what and why) In Q2, you could have plotted the errors in a graph showing the price more precisely and thus where the two error-curves cross, that is the market clearing price.