NumEconCopenhagen / projects-2024-jonas-mads

projects-2024-jonas-mads created by GitHub Classroom
MIT License
0 stars 0 forks source link

Peer feedback #2

Open bsj212 opened 5 months ago

bsj212 commented 5 months ago
  1. The most elegant solution in the project was:

In my opinion, the third question is the most elegant solution in the project. It is pretty easy to understand and it goes straight to the point. Question 6a is also pretty nice to see.

  1. The hardest section of code in the project to understand was:

The hardest section to understand is, I think, question 2 where you give a huge list of solutions which could be presented a nicer way, in a plot for example.

  1. This part of the project could be better documented:

You could have explained a bit more for each question what is your code doing and commenting a bit the results.

  1. An idea for an improvement/clarification could be:

You could have tried to use markdowns in order to separate the code cells, like this we would see more clearly the questions and will make the code prettier.

  1. An idea for an extension could be:

Like I said, maybe plot the values in question 2 so that we can see more clearly the result and use markdowns to separate code cells of the different question.