search

NumEconCopenhagen / projects-2024-jonas-mads

projects-2024-jonas-mads created by GitHub Classroom
MIT License
0 stars 0 forks source link

Feedback data project #4

Open dtf747 opened 5 months ago

dtf747 commented 5 months ago
  1. The most elegant solution in the project was: (explain what and why) • Fine plots of the different economic indicators and nice with descriptions below each plot.
  2. The hardest section of code in the project to understand was: (explain what) • The first code box gave rise to some confusion as you both import the packages needed to run the notebook and start the data loading and cleaning in the same code-box. It would give a better structure to separate the importing of packages to one code-box and the loadning and cleaning of data to another code-box.
  3. This part of the project could be better documented: (explain what) • I don’t understand how you use the py-file. It looks like it is exactly the same code as in the notebook, but you don’t refer to the py-file anywhere in the notebooks, so it seems a bit pointless.
  4. An idea for an improvement/clarification could be: (explain what and why) • Provide an introduction and conclusion – what is the point of observing the different indicators?
  5. An idea for an extension could be: (explain what and why) • Merge some of the datasets – it could e.g. be interesting to see how inflation affects GDP etc.