NumEconCopenhagen / projects-2024-jonas-mads

projects-2024-jonas-mads created by GitHub Classroom
MIT License
0 stars 0 forks source link

Peer feedback Model project #8

Open djb835 opened 4 months ago

djb835 commented 4 months ago

The most elegant solution in the project was: (explain what and why)

The whole ipynb file runs perfectly smooth without any issues. I really like how you implemented the Newton-Raphson method when you find the steady state. It is implemented effectively in your project and shows some very good iterative numerical techniques. I also really like your graphes - they are clean and easy to read.

The hardest section of code in the project to understand was: (explain what)

I dont really read a section that is hard to understand. But if i had to pick one i would chose the part where you implement the NR method within the solow model context. It has a bit more complex interpay between the mathematical derivation and the translation into coding.

This part of the project could be better documented: (explain what)

The model parameter setup could be improved a little bit. You do setup various of scenarios and analyzing the impact in your coding but i think the documenation could be better. You could consider to explain why certain parameter values has been chosen and how they will affect the outcomes.

An idea for an improvement/clarification could be: (explain what and why)

I find it hard to find ideas for improvement but one thing could be to seperate your coding a little bit more. For example you could seperate the functions for steady state parameter setting and plotting. Just a thought.

An idea for an extension could be: (explain what and why)

I dont have an extension for the coding, but you could consider to add some kind of conclusion in the end.