search

Numbertext / libnumbertext

Number to number name and money text conversion libraries in C++, Java, JavaScript and Python & LibreOffice Calc Extension
BSD 3-Clause "New" or "Revised" License
67 stars 46 forks source link

Don't depend on en_US.UTF-8 locale #43

Closed stbergmann closed 5 years ago

stbergmann commented 5 years ago

Instead, create locale with codecvt_utf8 facet on all platforms (even if codecvt_utf8 is deprecated since C++17). There is no guarantee that "en_US.UTF-8" is a supported locale name, so the locale constructor might throw a runtime_error. (See the discussion in the comments to https://gerrit.libreoffice.org/#/c/62508/ "Add check for en_US.utf8 locale" for a real-live example of issues caused by that.)

(And the and headers apparently need to be included always, regardless of NUMBERTEXT_BOOST.)

laszlonemeth commented 5 years ago

Many thanks for the fix! László