Numergy / signalslot

Simple signal slot implementation in Python
http://signalslot.rtfd.org
MIT License
48 stars 14 forks source link

Add missing 'weakrefmethod' module. #11

Closed sjlongland closed 8 years ago

sjlongland commented 8 years ago

This was missed, possibly because I didn't know how it was done at the time. The module really should declare this dependency up front so that pip install pulls it in automatically.

This fixes issues like the following: https://travis-ci.org/mriehl/fysom/jobs/104513915

Sliim commented 8 years ago

Hi @sjlongland

Thanks for your fix, but with this line I'm not still able to run a pip install . command.. Here is my output:

$ pip install .
Processing codz/signalslot
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-wpCRvh-build/setup.py", line 2, in <module>
        import signalslot.__version__ as signalslot_version
      File "signalslot/__init__.py", line 2, in <module>
        from .slot import Slot
      File "signalslot/slot.py", line 13, in <module>
        from weakrefmethod import WeakMethod
    ImportError: No module named weakrefmethod

It works for you?

jpic commented 8 years ago

Could we maybe revert f9a9841c08d78e2b4bf166a2d94efaa5699b7902 as well ?

sjlongland commented 8 years ago

Okay, better look into that, obviously pip doesn't look in setup.py output. (Still learning a lot regarding dependencies.)

sjlongland commented 8 years ago

Not quite sure why there's so many test failures all a sudden, but at least now I've relieved setup.py of its dependencies on weakrefmethod (and done a little housekeeping) so it now runs.

sjlongland commented 8 years ago

Failing tests seem to be due to changes in the mock and PEP8 test modules which never seemed to complain before. I can reproduce those on the master branch. I'll make that a separate pull request.

jpic commented 8 years ago

Works for me, ok for merge.

sjlongland commented 8 years ago

Turns out there wasn't much needed to fix that failing test: https://github.com/Numergy/signalslot/pull/12

Sliim commented 8 years ago

:+1:

Sliim commented 8 years ago

Released in signalslot 0.1.1. Thanks!

jpic commented 8 years ago

:guitar: