display separators as separators

NumeriusNegidius / Context-Search

A Firefox WebExtension that displays a context menu, that searches for the selected text.

https://addons.mozilla.org/firefox/addon/context-search-we/

Mozilla Public License 2.0

32 stars 9 forks source link

display separators as separators #23

Closed JohnGlassmyer closed 7 years ago

JohnGlassmyer commented 7 years ago

I keep a bookmark separator toward the end of my folder ("Searches") of keyword searches so that recently bookmarked / unsorted ones are separated from the list of previously sorted ones. (I suppose that other people use bookmark separators among their keyword-search bookmarks for other purposes.)

Currently, Context Search displays this bookmark separator as a blank entry in the context menu.

Would be great to have this separator displayed as a real menu separator.

NumeriusNegidius commented 7 years ago

Thanks for the suggestion! This was an issue in Firefox up until 57 and resolved in 1293853. The documentation hasn't even been updated. However, I have some working code that I will test a bit further, but I reckon this will be released within a week or so!

WolfganP commented 7 years ago

+1 on this one. I'm currently on FF57b6 and some separators are shown as empty items (some other aren't displayed at all). Thx!

NumeriusNegidius commented 7 years ago

Support for separators is included in version 1.0 available as we speak. In Firefox 57 and up.

WolfganP commented 7 years ago

Separators work perfectly. Thanks @NumeriusNegidius !