search

NumeriusNegidius / Context-Search

A Firefox WebExtension that displays a context menu, that searches for the selected text.
https://addons.mozilla.org/firefox/addon/context-search-we/
Mozilla Public License 2.0
32 stars 9 forks source link

Context-Search not functioning in new window #66

Closed salionPL closed 5 years ago

salionPL commented 6 years ago
  1. Go to http://release24.pl/ and click commentary button: screenshot_2018-10-31 release24 pl - release filmow seriali i gier
  2. New window is open
  3. Context-Search not functioning in this new window :(
NumeriusNegidius commented 5 years ago

As the website tries to hide all browser chrome in the popup windows (toolbars, locationbar, etc), it effectively stops the extension from opening a new tab within that window, throwing an error.

In a0f70a6, the code that creates a new tab is now a promise, and if an error is thrown, it tries to create a new tab without openerTabId. I'm still testing it out, and if nothing breaks will be released in the next version.