NumyAddon / TalentLoadoutManager

https://www.curseforge.com/wow/addons/talent-loadout-manager
3 stars 2 forks source link

Feature suggestion: Allow to lock talent loadouts #5

Open tflo opened 1 year ago

tflo commented 1 year ago

It would be great if we could lock a talent loadout, i.e protect it against modifications or deletion.

Why?

A simple Lock option would protect me from my stupidness πŸ˜‰

Implementation suggestions

The lock/unlock could be implemented via context menu (right-click menu) of a loadout. A little lock icon before (or after) the loadout name in the sidebar would be just the icing on the cake.

The Locked state should make it impossible to save changes to a loadout, to delete it, or to rename it.

Notification

The user should be notified about the Locked state via a pop-up dialog box, telling them that the loadout is locked and – another icing on the cake – offering an Unlock button and a Crete New Loadout button, in addition to the Cancel button.

Now, I see to possibilities when the box should be popped up:

A) Right away when I try to modify a locked loadout, or… B) only when I try to save, delete, or rename a locked loadout.

ATM, I tend to think that option B would be better, because it still allows to temporarily modify a loadout and load it into the Blizz loadouts ("Apply Changes"), and later to revert back by simply activating the saved loadout in TLM again.

However, option A would be "cleaner" (and probably more transparent), and it would educate me (i.e. force me) to always create a clone loadout for tweaks or experiments, even temporarily.


Thanks in advance for considering my suggestion, and many thanks for this really useful addon!

– Tom

Numynum commented 1 year ago

I'll put this on my list πŸ™‚

though I would probably start of by simply disabling the save/rename/delete buttons, and disable the import-into-current-custom-loadout option; rather than a popup

tflo commented 1 year ago

My proposed implementation details is just how I would do it if it was my addon (and if I had the time πŸ˜‰).

Of course any implementation would be welcome, and just disabling the buttons and menu entries would be perfectly fine!

BTW, speaking of disabling buttons: I noticed that the Save button is always enabled, even if there is nothing to save (no changes made). This makes me always click the button, even if I only looked at a loadout. Probably an OCD thing of mine, but if this button was dimmed if there is nothing to save, that would be great!