NunoDasNeves / slp-to-mp4

Convert slippi replay files for Super Smash Bros Melee to videos
MIT License
46 stars 10 forks source link

Issue with command not finding the build #22

Open warjax opened 1 year ago

warjax commented 1 year ago

I'm trying to run the command, "slp-to-mp4.py C:\Users\Jake\Documents\Slippi\FoxReview.slp Foxplay4Review.mp4' for instance, and keep getting this runtime error : RuntimeError: C:/Users/Jake/AppData/Roaming/Slippi Launcher/playback\Dolphin.exe does not exist Worth noting here that I do have it pointing to this folder, and that there is slippi dolphin renamed as dolphin.exe. Attaching the screenshot image

Any Ideas why this might be struggling to find this?

warjax commented 1 year ago

To tack on an additional piece of information - here is my config_windows file:

{ "melee_iso": "C:/Melee/Games for Dolphin/Super Smash Bros. Melee (USA) (En,Ja) (v1.02).iso", "dolphin_dir": "C:/Users/Jake/AppData/Roaming/Slippi Launcher/playback", "ffmpeg": "C:/Users/Jake/Documents/Slippi/Convert/ffmpeg-2023-01-09-git-13d04e30d7-full_build/bin/ffmpeg.exe", "resolution": "720p", "widescreen": true, "bitrateKbps": 16000, "parallel_games": "recommended", "remove_short": true, "combine": true }

warjax commented 1 year ago

Additionally, I am on the latest build for Slippi, and 3.10 for Python

davisdude commented 1 year ago

This has been an issue for a while now - see https://github.com/NunoDasNeves/slp-to-mp4/issues/16. It's been fixed in https://github.com/NunoDasNeves/slp-to-mp4/pull/21, but the author seems inactive. I recommend using my fork, which should be fully functional.


That being said, something about your setup does seem odd to me. It's weird that your Slippi Dolphin has no .exe extension. What happens when you double click either of the dolphin executables?

masterquest91 commented 1 year ago

@davisdude said:

That being said, something about your setup does seem odd to me. It's weird that your Slippi Dolphin has no .exe extension. What happens when you double click either of the dolphin executables?

They are hiding file extensions in Explorer, so it might work if they rename it to simply "Dolphin". Or show extensions and verify it doesn't say "Dolphin.exe.exe".

@warjax: Not sure when #21 will get implemented, but you can fix it now with a small manual tweak to config.py, line 8 like so: DOLPHIN_NAME = 'Slippi Dolphin.exe'

My config file as follows:

{
    "melee_iso": "D:\\GAMES\\roms\\gc\\Super Smash Bros. Melee (USA) (En,Ja) (v1.02).iso",
    "dolphin_dir": "C:\\Users\\masterquest91\\AppData\\Roaming\\Slippi Launcher\\playback",
    "ffmpeg": "C:\\Program Files\\ffmpeg\\ffmpeg.exe",
    "resolution": "1080p",
    "widescreen": true,
    "bitrateKbps": 16000,
    "parallel_games": "1",
    "remove_short": true,
    "combine": false
}

You may notice that I had to escape the \ character in the file path. I don't know too much about python, but I would have thought that defining the path in "" would not make this necessary.

davisdude commented 1 year ago

They are hiding file extensions in Explorer

But in the original screenshot, some of the files have extensions, which is why I'm confused. Maybe it's some Windows jank :shrug:.

I don't know too much about python, but I would have thought that defining the path in "" would not make this necessary.

Well the config file is JSON, not Python. That format is correct if you're using \s for your paths. See here for more (note that "\" is called a "reverse solidus").