Nutomic / ensichat

Project discontinued
Mozilla Public License 2.0
145 stars 22 forks source link

Where is the add contacts button? #40

Closed deavmi closed 8 years ago

deavmi commented 9 years ago

I can longer find the button to add contacts in EnsiChat.

Nutomic commented 9 years ago

You can view your connections (and add them as contacts) if you click on the "x Connections". Do you think that should be clarified somehow?

And I will add the button back in with a different functionality as described in #36.

deavmi commented 9 years ago

It would make more sense to have the add contacts page accessible via an "Add contacts" button in the main menu.

Sent from my iPod

On Sep 26, 2015, at 7:19 PM, Felix Ableitner notifications@github.com wrote:

You can view your connections (and add them as contacts) if you click on the "x Connections". Do you think that should be clarified somehow?

And I will add the button back in with a different functionality as described in #36.

— Reply to this email directly or view it on GitHub.

Nutomic commented 9 years ago

Hm, the thing is it's not really an "add contacts" screen, it's actually "list connections" (with an option to add them as contacts).

deavmi commented 9 years ago

Oh I see. What about having two separate screens. One or contacts to add and one for contacts added (MainActivity)

deavmi commented 9 years ago

Or display who are friends with a tag next to the contact.

Nutomic commented 9 years ago

That's how it currently is (basically): MainActivity shows contacts, and clicking on connections shows connected devices.

deavmi commented 9 years ago

Well you could show all contacts not in the added contacts database and then allow the user to add them.

Sent from my iPod

On Sep 29, 2015, at 10:16 PM, Felix Ableitner notifications@github.com wrote:

Hm, the thing is it's not really an "add contacts" screen, it's actually "list connections" (with an option to add them as contacts).

— Reply to this email directly or view it on GitHub.

Nutomic commented 9 years ago

I'm not sure what you mean, can you clarify this?

deavmi commented 9 years ago

Like, have MainActivity show only added contacts and then have an Add COntacts page which shows contacts not added that it has found whilst doing a Bluetooth scan.

Nutomic commented 9 years ago

That's exactly how it works right now. Contacts to add being shown when you click on "Connections" in the Actionbar.

deavmi commented 9 years ago

Oh okay. I thought it would be unclear that one would have to tap the connections button to add contacts.

Sent from my iPod

On Oct 1, 2015, at 1:55 PM, Felix Ableitner notifications@github.com wrote:

That's exactly how it works right now. Contacts to add being shown when you click on "Connections" in the Actionbar.

— Reply to this email directly or view it on GitHub.

Quiark commented 8 years ago

Now it's totally unclear how to connect with someone. I had to google here to find that I have to click on the titlebar.

deavmi commented 8 years ago

Now it's totally unclear how to connect with someone. I had to google here to find that I have to click on the titlebar.

I felt the same way.

Nutomic commented 8 years ago

Do you guys have a different idea how to show this? I think it's useful to show the number of connections, and I can't think of another place for that. And I think it makes sense to add contacts from the list of connections (at least once you know it).

That said, I'm totally open for suggestions, I just can't think of anything better.

Quiark commented 8 years ago

Just add the material style big + button. Or a menu item. It's not clear that you can click on the number of connections.

On Thu, 3 Dec 2015 21:39 Felix Ableitner notifications@github.com wrote:

Do you guys have a different idea how to show this? I think it's useful to show the number of connections, and I can't think of another place for that. And I think it makes sense to add contacts from the list of connections (at least once you know it).

— Reply to this email directly or view it on GitHub https://github.com/Nutomic/ensichat/issues/40#issuecomment-161642203.

deavmi commented 8 years ago

The plus button could work. The cross. :)

Nutomic commented 8 years ago

I just don't like that there would be two buttons for the same action. But it does seem to be the best solution.

Quiark commented 8 years ago

That's exactly the kind of programmer thinking that leads to bad UX :)

On Fri, 4 Dec 2015 00:32 Felix Ableitner notifications@github.com wrote:

I just don't like that there would be two buttons for the same action. But it does seem to be the best solution.

— Reply to this email directly or view it on GitHub https://github.com/Nutomic/ensichat/issues/40#issuecomment-161707285.

Nutomic commented 8 years ago

Maybe you're right :D

deavmi commented 8 years ago

Yay! :) thanks @Nutomic