search

Nuytemans-Dieter / BetterSleeping

A Spigot plugin that will make sleeping on servers less of a hassle
https://www.spigotmc.org/resources/bettersleeping-1-12-1-15.60837/
Apache License 2.0
84 stars 73 forks source link

lp verbose spam #265

Closed SynergiAios closed 2 years ago

SynergiAios commented 3 years ago

Potential bug

This plugin does spam the /luckperms verbose output because it constantly checks the bypass permission for every player. /lp verbose becomes unusable with this plugin. I always have to disable the plugin first to work with the verbose of luckperms.

Any workaround or why even check this permission every tick?

Ultimation commented 2 years ago

I'm seeing this too - latest version of paper 1.17 + plugin.

JonMagon commented 2 years ago

I can confirm

[12:03:26 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false                                                                                                                                                                                                   [5/4704]
[12:03:26 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false                                                                                                                                                                                                           
[12:03:26 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false                                                                                                                                                                                                           
[12:03:26 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false                                                                                                                                                                                                           
[12:03:26 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false                                                                                                                                                                                                           
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false                                                                                                                                                                                                           
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:27 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:28 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:29 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
[12:03:29 INFO]: [LP] VB > jonmagon - bettersleeping.bypass - false
> lp verbose off

I'm taking the workaround because I don't need this check: Replace player.hasPermission("bettersleeping.bypass") with false https://github.com/Nuytemans-Dieter/BetterSleeping/blob/bc9b23fa201bb839cd4a8c06324a36af31681972/src/main/java/be/betterplugins/bettersleeping/model/BypassChecker.java#L67

Nuytemans-Dieter commented 2 years ago

Will see what I can do about this! Sorry for the inconvenience