search

Nuzair46 / BlockTheSpot-Mac

Spotify Ad blocker for MacOS
GNU General Public License v3.0
1.35k stars 82 forks source link

I still keep getting ads. I'm I doing something wrong? #65

Closed dawoodjee closed 11 months ago

dawoodjee commented 12 months ago
image image

I'm on macos intel

image

Any ideas or tests I should check?

Nuzair46 commented 12 months ago

likely an issue with new update. will look into this over the weekend

nakheel77 commented 11 months ago

likely an issue with new update. will look into this over the weekend

Many thanks for update!

mnusurov commented 11 months ago

@Nuzair46 Maybe this repo will give you insights as it's the latest supported version is 1.2.21.1104.g42cf0a50

tikumo commented 11 months ago

Ran the script thursday, perhaps they found a way to unblock this blocker. Hope you find it!

image

Nuzair46 commented 11 months ago

Sadly it will take some time for me to work on this. I recently sold my Macbook and Im waiting to get one next month. You guys will have to wait until I get a new one to test the changes.

jiwaCh commented 11 months ago

any update?

or alternative project?

mnusurov commented 11 months ago

any update?

or alternative project?

Check here

Nuzair46 commented 11 months ago

Sorry. Give me some time. In the meantime feel free to use the alternative

skupjoe commented 11 months ago

https://github.com/SpotX-Official/SpotX-Bash

This project works on Mac + Linux for latest version. Confirmed both on Apple Silicon + Intel.

@Nuzair46 no disrespect- thank you for all your work here- but wondering why continue to support this fork and not centralize around SpotX-Bash?

Is there anything that SpotX-Mac provides that the other doesn't?

eatmyaspirin commented 11 months ago

SpotX-Official/SpotX-Bash

This project works on Mac + Linux for latest version. Confirmed both on Apple Silicon + Intel.

@Nuzair46 no disrespect- thank you for all your work here- but wondering why continue to support this fork and not centralize around SpotX-Bash?

Is there anything that SpotX-Mac provides that the other doesn't?

The repo code hasn't been updated since jetfir3 started SpotX-Bash. See the SpotX-Mac repo history here which seems to mostly be jetfir3 - https://github.com/Nuzair46/SpotX-Mac/commits/main

Nuzair46 commented 11 months ago

@eatmyaspirin Dude, SpotX-Mac was working until couple of weeks ago. Nothing against jetfire as he helped a lot on this repo, but nobody is claiming anything here, Infact he is still mentioned in the readme for his contributions. I started this port a while back to bring SpotX for mac and I was more than thankful to Jetfire for the contributions he did after (during when i was busy with other projects and work). If you were on discord, you probably know the whole drama and we want to put an end to this. Im not entitled to work on this repo and I have announced how I feel about Spotify patches in general in the past on discord (icymi, I really dont feel like spending time on these after all that drama). I might update this repo or may not. You are free to contribute if you want. But I really lost my interest after being in this scene for 5 years maintaining and contributing however I can (If you doubt it, look at BlockTheSpot repo, and If not for my initiative for SpotX-Mac, we would not be having a patch until someone thought of it). tbh, i just don't have the motivation to work on these. And some people who use these patches like BlockTheSpot/SpotX are one of the most entitled and toxic community I've came across for an open source project which really puts me to question if I should be doing this or not.

I don't like promoting amd64fox's SpotX or Jetfire's SpotX-Bash after I got blocked to contribute because of a dispute over a logo. But here I'm still maintaining the repo's and providing support on discord for the people who still use it. Please stop this, I hope the drama doesn't come over to Github.

Im hiding these comments as off topic

Nuzair46 commented 11 months ago

@skupjoe Its pretty much same and its actively maintained. Im just keeping this repo as this is the first Spotify adblocker based on SpotX for mac.

vantough commented 11 months ago

hey man this bs repo code hasn't been updated since jetfir3 (og creator of this repo) started SpotX-BashSee the SpotX-Mac repo history here which seems to mostly be jetfir3 - https://github.com/Nuzair46/SpotX-Mac/commits/main (check)

I'm not sure why people are still using this repo

Nuzair46 commented 11 months ago

Oh wow. There is no point discussing this here with you all. You clearly don't know how to differentiate an initial commit. Nobody is asking you to use this. Its upto you. But please take your nonsense somewhere else. Just to make it easy for you to understand, SpotX mac was stable since Jetfires last commit. SpotX-Bash was also stable too until Spotify update broke both patches couple of weeks ago and SpotX bash is now updated. This repo is not. Both repos were inactive for almost since January because of stability.

Please end this off-topic conversation here or I will have to lock this thread.

jetfir3 commented 11 months ago

SpotX-Bash was also stable too until Spotify update broke both patches couple of weeks ago and SpotX bash is now updated. This repo is not. Both repos were inactive for almost since January because of stability.

I don't want to contribute to the "off-topicness" or debate who did what but for the sake of accuracy I must reply to this bit.

SpotX-Bash was not dormant until a few weeks ago. I rebase and squash on occasion so dates do not reflect code updates at all.

SpotX-Bash is often updated weekly (or more) to support all code changes, add new features, handle all new experimental features and ensure all SpotX-Bash features remain working as they should with every build, current and previous (Spotify updates weekly on average).

Ad handling was updated and changed months ago as new handling was added to Spotify's code and some users were getting remote configs from Spotify forcing the change. Apparently a majority of users were lucky and didn't run into the change until more recently (based on some users in this thread, anyway).

And now to get back on topic... the creator of this specific issue has selected "premium user setup" (-p) as a mistake (I assume they thought the patches give them premium)... so no ad patching or additional patches for free-tier users was done.. so of course there are going to be ads. Whether the user would get ads or not after running SpotX properly (without -p).. I can't say. All depends on their remote config pushed by Spotify.

Nuzair46 commented 11 months ago

Fixed

jetfir3 commented 11 months ago

Fixed

Your "fix" was taking all the exact ad patches from https://github.com/SpotX-Official/SpotX-Bash while also removing any mention of credits + adding your own name to the script now?

Nice work.

Nuzair46 commented 11 months ago

@jetfir3 funny you mention that after you make the exact clone for the repo. Please don't mention how many commits you made. I know you did a lot. But figuring out for days to port either BlockTheSpot or SpotX was hard and if not for the initial commit done here, Im pretty sure a mac port would still not be released as many used to think it was impossible. Sorry not sorry. But you should've realised what you did when you created a new repo instead of forking, without crediting the original idea.