NvChad / base46

NvChad's base46 theme plugin with caching ( Total re-write )
Other
188 stars 194 forks source link

Theme changes are not picked if the custom folder is symlinked #177

Closed dgmora closed 1 year ago

dgmora commented 1 year ago

This is related to some issues I was reporting in https://github.com/NvChad/base46/issues/173.

I'm not sure if this is a priority, but I just wanted to report that it happens. If the custom folder is a symlink, changes are not picked.

mkdir test/custom

Add chadrc.lua to that folder:

local M = {}

M.ui =  {
  theme = "solarized_dark",
  hl_override = {
    CursorLine = {
       bg = "blue",
       fg = "green",
    },
  },
}

M.mappings = {}

return M

Using this dockerfile:

FROM alpine:latest
WORKDIR /root
RUN apk  add git nodejs neovim ripgrep build-base bash --update
RUN git clone https://github.com/NvChad/NvChad ~/.config/nvim
CMD bash

Build the image

docker build -t nvchad .

This works (copying config to the right place), theme and highlight change live.

docker run -ti --rm -v $PWD/test/custom:/root/test/custom nvchad
# inside
cp -r /root/test/custom /root/.config/nvim/lua/custom
nvim ~/.config/nvim/lua/custom/chadrc.lua
# edit CursorLine colors change real time
exit docker

This doesn't (symlink), changes in the file don't seem to be picked, even after exiting.

docker run -ti --rm -v $PWD/test/custom:/root/test/custom nvchad
# inside
ln -s /root/test/custom /root/.config/nvim/lua/custom
nvim ~/.config/nvim/lua/custom/chadrc.lua
# edit CursorLine colors doesn't change anything, even after re-entering nvim.
siduck commented 1 year ago

hmm let me test it here

siduck commented 1 year ago

I get this error when using the symlinked custom dir

image

do you get it?

dgmora commented 1 year ago

No, everything loads fine but the colors specified aren't really right

On Sun, Apr 2, 2023, 14:34 Sidhanth Rathod @.***> wrote:

I get this error when using the symlinked custom dir

[image: image] https://user-images.githubusercontent.com/59060246/229353067-0357aaf7-2f5f-4634-972e-cc5f464a0870.png

do you get it?

— Reply to this email directly, view it on GitHub https://github.com/NvChad/base46/issues/177#issuecomment-1493320281, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3RIEGYY632EKLBSFJDWGLW7FW5DANCNFSM6AAAAAAWO4B7CM . You are receiving this because you authored the thread.Message ID: @.***>

siduck commented 1 year ago

hmmm weird, i'll test it this weekend

siduck commented 1 year ago

hi @dgmora its finally fixed now! sorry for taking too long