NvChad / base46

NvChad's base46 theme plugin with caching ( Total re-write )
Other
187 stars 194 forks source link

Highlights add & override not working #185

Closed notokrs closed 1 year ago

notokrs commented 1 year ago

Describe the bug Adding hl_override & hl_add in chadrc.lua doesn't seem to work

To Reproduce Steps to reproduce the behavior:

  1. Change highlights.lua file
  2. Add hl_override & hl_add in chadrc.lua
  3. overrided & added highlight not apllied

Expected behavior add & override highlight config applied

Screenshots chadrc.lua 2023-04-21_23-19

highlights.lua 2023-04-21_23-20

config not applied 2023-04-21_23-29

Desktop (please complete the following information):

siduck commented 1 year ago

https://user-images.githubusercontent.com/59060246/233847771-603ded53-2225-4d7a-abdb-03df60b7b99b.mp4

works. please save your file

notokrs commented 1 year ago

yeah, hl_override is not working until i change the theme and it's working now. But the hl_add to nvim-tree is not working, any suggestions?

siduck commented 1 year ago

@notokrs i dont get what you mean, please make a video!

notokrs commented 1 year ago

nvim tree opened folder name not applied

https://user-images.githubusercontent.com/79308398/234248191-4f529fc5-6bae-491e-92e7-c37ba80aa57c.mp4

jamwil commented 2 weeks ago

This still doesn't work. Perhaps because I'm still using v2.0 and there's a mismatch somewhere, but neither the override or the add are functional at all, on MacOS or Windows.

For instance, even the default override which sets Comment to italic has never worked. If I run :Telescope highlights, there is only @comment, which I can't figure out how to set.

jamwil commented 2 weeks ago

Got it working with this:

M.override = {
  Comment = {
    fg = "#999999",
    italic = true,
  },
  ["@comment"] = {
    fg = "#999999",
    italic = true,
  },
  LineNr = {
    fg = "#999999",
  },
  SignColumn = {
    fg = "#999999",
  },
}

There appears to be some cacheing going on here which can muddle things up. If you edit the config directly, it updates in place. I found that when managing dotfiles externally using something like chezmoi, I would need to purge my nvim data folder for the these changes to take hold.

siduck commented 2 weeks ago

@jamwil just change your base46_cache path? go to your main init.lua file

vim.fn.stdpath("config") .. "/base46_cache"