search

NvChad / base46

NvChad's base46 theme plugin with caching ( Total re-write )
Other
195 stars 198 forks source link

Update GitHub Themes #263

Open AntonPieper opened 10 months ago

AntonPieper commented 10 months ago

The current "github_dark" and "github_light" themes do not align with the actual GitHub Theme. Maybe it is time to update them (particularly the dark theme) to align with the VSCode GitHub Themes Extension default themes (GitHub Dark Default and GitHub Light Default). If the newer versions are too different, they could also be called "github_dark_default" and "github_light_default" respectively to match the VSCode extension's naming scheme.

siduck commented 10 months ago

prs are welcome

AntonPieper commented 10 months ago

I have tried for a few hours now, the challenging part for me is figuring out what each base30 / base16 value actually represents. To me it seems like many values don't change anything because I am not using the full set of features of NvChad / don't know where to look. It would be nice if there was some example source code file where every color is used or additional information in the docs. Nonetheless I am very great ful for your work and I will keep trying to implement this revision of the GitHub theme

siduck commented 10 months ago

check the readme of this repo