NvChad / base46

NvChad's base46 theme plugin with caching ( Total re-write )

Other

187 stars 194 forks source link

Themes are too hard to see #78

Closed nullchilly closed 2 years ago

nullchilly commented 2 years ago

Radium

radium

Top right window with C++ has too many red brackets and parentheses
vim-matchup uses white bg...
Can barely see Visual (Selected texts)

Tokyonight

tokyonight

Brackets and parentheses actually fit nicely with the theme
vim-matchup still using white bg instead of grey?
Can see Visual easily

Help to modify

I attempted to modify base0F to the same as tokyonight's and make MatchParen only show fg and Visual to base04

However, I don't have a sense of color. While it ended up much clearer to my eyes at the same time it is uglier. Can you help me out :<

siduck commented 2 years ago

i will revert the change that made matchparen white, does this look good to you?

nullchilly commented 2 years ago

This is the old MatchParen highlight

   MatchParen = {
      bg = theme.base03,
   },

I think bg = theme.base02 (same as Visual is better)

While it is true that darker looks better, it is still horrible on super dark theme. On the left is radium theme, you can barely even see the visual selection. I will go crazy daily driving this

On the right is what I want it to look like, a clear visual selection, please take this into consideration. While I can always override colors by myself it's undeniable that the theme lacks too much function just for the look of it.

siduck commented 2 years ago

@nullchilly It will take a month for me to polish all the themes https://github.com/NvChad/base46/issues/67 so you need to wait ._.