NvChad / base46

NvChad's base46 theme plugin with caching ( Total re-write )
Other
210 stars 203 forks source link

Wrong colors in diffmode #84

Closed tmaegel closed 2 years ago

tmaegel commented 2 years ago

The onedark theme of nvchad does not highlight colors correctly in diffview.

Started neovim diff mode with configured nvchad and onedark-theme. image

Started neovim diff mode with disables plugins and options. image

Are these colors not taken into account by the theme? How can I override them?

UPDATE: Theses Colors are not set in de the default themes. I overwrited the following colors and that solves the problem for me.

DiffAdd = {
  fg = "none",
  bg = colors.diff_add,
},
DiffChange = {
  fg = "none",
  bg = colors.diff_change,
},
DiffChangeDelete = {
  fg = "none",
  bg = colors.diff_delete,
},
DiffDelete = {
  fg = "black",
  bg = colors.diff_delete,
},
DiffText = {
  fg = "none",
  bg = colors.diff_text,
},
GitSignsAdd = {
  bg = "black",
},
GitSignsChange = {
  bg = "black",
},
GitSignsDelete = {
  bg = "black",
},
SignColumn = {
  bg = "black",
},
FoldColumn = {
  bg = "black",
}
siduck commented 2 years ago

https://github.com/NvChad/base46/blob/a8ac8880e2b3f962e225af4399a5d9ffa5701cde/lua/integrations/nvchad.lua#L49 we have those hl groups defined