search

NvChad / nvim-colorizer.lua

Maintained fork of the fastest Neovim colorizer
Other
708 stars 47 forks source link

feat: Add inline virtualtext mode #63

Closed mehalter closed 2 months ago

mehalter commented 1 year ago

This adds a new inline mode to use the new inline virtual text features of Neovim v0.10 (currently nightly)

2023-05-23_11:45:53_screenshot

olrtg commented 1 year ago

Thanks for your contribution.. I'm using your fork already! Is it possible to also add an option to change the location of the virtualtext (start/end of the color)?

olrtg commented 1 year ago

image

Also I'm wondering why your virtualtext is separated by one space and mine not 🤔

mehalter commented 1 year ago

@olrtg Changing start and end would be a great option! I would want to hear back from the maintainers to see what direction they want to go with these types of options. Sadly I haven't heard anything quite yet, so they might not be interested in this type of feature?

Also for your second comment, I personally changed the virtualtext option that already exists to add a space to make it that way. Basically this PR just adds the ability to enable inlay hints but it piggy backs on the already existing option for setting what the actual virtual text is which in the case of not having inlay hints it shouldn't have a space.

olrtg commented 1 year ago

@mehalter Thank you so much for the answer! I didn't realized that there was an option for changing that! Now it's working like yours 🤘🏽 And well, we'll have to patiently wait I guess.

mehalter commented 2 months ago

I suppose this was superseded by #85 I'll go ahead and close this.