NvChad / ui

Lightweight & high performance UI plugin for nvchad
GNU General Public License v3.0
208 stars 124 forks source link

sign_define is deprecated. #303

Closed synqqrawr closed 2 months ago

synqqrawr commented 2 months ago

sign_define on current nightly (NVIM v0.11.0-nightly+3e6cec0) is deprecated and now is replaced with vim.diagnostic.config

siduck commented 2 months ago

@synqqrawr we only support stable stuff, not nightly, tons of apis are deprecated on nightly, so please use LTS

lucario387 commented 2 months ago

@synqqrawr we only support stable stuff, not nightly, tons of apis are deprecated on nightly, so please use LTS

https://neovim.io/doc/user/deprecated.html#_deprecated-features

Btw sign_define is depreacated in 0.10 aka stable. Not nightly @siduck

siduck commented 2 months ago

Hmm, strange I didn't get any warnings at all

siduck commented 2 months ago

image

is this the new way?

synqqrawr commented 2 months ago

Yes, that should do it.

siduck commented 2 months ago

https://github.com/NvChad/ui/commit/c7b11478f4079fdaa6b5395dae08fdfe4c1c1cfe