NvChad / ui

Lightweight & high performance UI plugin for nvchad
GNU General Public License v3.0
298 stars 135 forks source link

Fix :MasonInstallAll issue #306

Closed alexandr-martirosyan closed 4 months ago

alexandr-martirosyan commented 4 months ago

Issue described here

siduck commented 4 months ago

that data is optional and users must only use it if they want to install mason pkg which isnt configured by lspconfig, nvim-lint, conform

alexandr-martirosyan commented 4 months ago

that data is optional and users must only use it if they want to install mason pkg which isnt configured by lspconfig, nvim-lint, conform

Yes, but, the current implementation does not allow for installing packages such as "nomicfoundation-solidity-language-server" using the mason.opts.ensure_installed = { "nomicfoundation-solidity-language-server" } method, or any other package whose name differs in the Mason registry.

siduck commented 4 months ago

you dont need to add that in ensure_installed if you're already using its lspconfig.setup call, the masoninstallall cmd will capture from there

alexandr-martirosyan commented 4 months ago

Yes, I’m aware of that. However, my current Neovim setup relies on the ensure_installed option in Mason.opts, which functioned correctly until the recent changes. Therefore, I need to continue using the ensure_installed field. Could you clarify if there has been an architectural change requiring us to use the values from this link instead of the actual names from the Mason registry? For example, should I use solidity_ls_nomicfoundation instead of nomicfoundation-solidity-language-server, which worked previously?

siduck commented 4 months ago

require("lspconfig").solidity_ls_nomicfoundation.setup()

siduck commented 4 months ago

ah wait, i understand the issue now! you can try this one

image

alexandr-martirosyan commented 4 months ago

ah wait, i understand the issue now! you can try this one

Should I update my pull request with the code you’ve provided?

siduck commented 4 months ago

yes