search

NvChad / ui

Lightweight & high performance UI plugin for nvchad
GNU General Public License v3.0
288 stars 132 forks source link

Add default diagnostic float border #334

Closed trongthanh closed 2 months ago

trongthanh commented 2 months ago

Is your feature request related to a problem? Please describe.

Latest nvim 0.10 LSP diagnostic & documentation floats by default have no borders, making them difficult to read (blended with buffer's text)

Describe the solution you'd like

Add the global setting by overriding vim.lsp.util.open_floating_preview as described in nvim-lspconfig wiki.

Describe alternatives you've considered

Instead of overriding vim.lsp.util.open_floating_preview in nvchad plugin, do it in the starter repo with explanation comments.

Screenshot Screenshot 2024-09-09 at 12 09 31 PM LSP Documentation float (built-in key binding shift K) has no borders

Screenshot 2024-09-09 at 12 10 39 PM LSP Documentation float with borders

Screenshot 2024-09-09 at 12 10 12 PM The override setting

siduck commented 2 months ago

send a PR and change this file https://github.com/NvChad/ui/blob/v2.5/lua/nvchad/lsp/init.lua#L12

siduck commented 2 months ago

@trongthanh you got transparent=true?

trongthanh commented 2 months ago

@siduck I don't get it?

siduck commented 2 months ago

nvm it.

before the floating window had some sort of bg color, now it doesnt, weird. Does it not use normalfloat hlgroup anymore :thinking: