Debug: Fix data type issue in JacobianBody and JacobianSpace

NxRLab / ModernRobotics

Modern Robotics: Mechanics, Planning, and Control Code Library --- The primary purpose of the provided software is to be easy to read and educational, reinforcing the concepts in the book. The code is optimized neither for efficiency nor robustness.

http://modernrobotics.org/

MIT License

1.92k stars 809 forks source link

Debug: Fix data type issue in JacobianBody and JacobianSpace #6

Closed one-for-all closed 6 years ago

one-for-all commented 6 years ago

Hi, this is my first time actually making a serious pull request. If there is any issue with formatting and stuff, please do not hesitate to point them out. Thanks!

This request fixes a bug that I encountered which was: If Blist or Slist has data type int, Jb and Js would inherit its data type, and cause float to be automatically floored to int when assigning their columns.

jarvisschultz commented 6 years ago

Thank you for pointing out this issue, and for the PR. Your PR was not merged because you happened to submit while the repo was undergoing a significant re-organization in an effort to better package the library. However, your change was incorporated in this commit. So I'm closing this PR for now.