search

Ny0n / Nys_ToDoList

WoW addon that creates a simple in-game To-Do list
https://legacy.curseforge.com/wow/addons/nys-todolist
7 stars 5 forks source link

NA weekly reset support #33

Closed icbat closed 3 weeks ago

icbat commented 4 weeks ago

I noticed that my weeklies didn't reset on Tuesday like I expected; from glancing at the code it looks like it's always resetting weeklies on EU-time aka Wednesday.

You might be able to fork behavior based on the region (available via GetCurrentRegion) or you could potentially do some more complicated math if you prefer using C_DateAndTime.GetSecondsUntilWeeklyReset().

I'm happy to try to make a PR if that would help! Thanks for the lovely addon, it really solves a lot of my needs!

Ny0n commented 4 weeks ago

Hello, you're right, the addon is setup on EU time by default, though you can edit the weekly reset day through the in-game options, so I never really updated the code.

Thanks for the suggestions, considering that you're not the first one to tell me this, I'll probably fix this in the code for the next update 😉

icbat commented 4 weeks ago

Thanks for taking a look! I actually can't find it on the options for the addon, though maybe I'm just missing it. Thank you either way!

Ny0n commented 4 weeks ago

It's configured for each tab, so in the addon options > tabs > any tab > auto-reset

icbat commented 4 weeks ago

Aha, I did not know I could click into the tab options! Thank you!