Nyalab / caniuse-api

request the caniuse data to check browsers compatibilities
MIT License
356 stars 27 forks source link

Cleaner build process #23

Closed ooflorent closed 9 years ago

ooflorent commented 9 years ago
Nyalab commented 9 years ago

Thanks ! :smiley_cat:

MoOx commented 9 years ago

Not sure import fs from "fs" is right according to how import is supposed to behave (return default entry by default ?)

MoOx commented 9 years ago

Where is the postinstall hook ? If you do that on prepublish, you are doing it wrong. You will provide a features.js that will be frozen according to the publish date but when a user will install it, you are going to get an outdated listing since caniuse db can get new features as patch.

MoOx commented 9 years ago

This PR looks like a regression :(