1.3.0 to enable in browser usage.

Nyalab / caniuse-api

request the caniuse data to check browsers compatibilities

MIT License

356 stars 27 forks source link

1.3.0 to enable in browser usage. #26

Closed MoOx closed 9 years ago

MoOx commented 9 years ago

@Nyalab here is a proposal for 1.3.0

Added: better exception messages
6to5 to babel (note the babel-tape-runner thing + lots of import * as changes)
Added: full browserify compatibility (by avoiding dynamic require)
Optimisation for node: lazyload hardcoded require when needed.

If you are ok with that, just tell me so I can merge and release.

MoOx commented 9 years ago

Build now pass. See #19 workaround

ooflorent commented 9 years ago

Can you move caniuse-db and shelljs deps to devDependencies?

MoOx commented 9 years ago

caniuse-db is a requirement as well as shelljs since it's used in postinstall hook. What are your thinking about ?

ooflorent commented 9 years ago

shelljs and caniuse-db are only used during the build and though should not be included as dependencies but dev ones.

MoOx commented 9 years ago

caniuse-api needs those 2 packages. For real. shelljs is used to launch the features.js with fresh data on install from caniuse-db. Not before publishing. On install by the end user.

You already try to make some changes for this package but they got reverted because they were breaking everything.

Are you just using caniuse-api somewhere?

MoOx commented 9 years ago

Also, that totally not the point of the PR so please use another issue for asking those weird changes that don't solve anything :p

Nyalab commented 9 years ago

looks good to me, you can merge when you want :shipit: