Closed MoOx closed 9 years ago
Build now pass. See #19 workaround
Can you move caniuse-db
and shelljs
deps to devDependencies
?
caniuse-db is a requirement as well as shelljs since it's used in postinstall hook. What are your thinking about ?
shelljs
and caniuse-db
are only used during the build and though should not be included as dependencies
but dev ones.
caniuse-api needs those 2 packages. For real.
shelljs is used to launch the features.js
with fresh data on install from caniuse-db. Not before publishing. On install by the end user.
You already try to make some changes for this package but they got reverted because they were breaking everything.
Are you just using caniuse-api somewhere?
Also, that totally not the point of the PR so please use another issue for asking those weird changes that don't solve anything :p
looks good to me, you can merge when you want :shipit:
@Nyalab here is a proposal for 1.3.0
import * as
changes)If you are ok with that, just tell me so I can merge and release.