search

Nyalab / caniuse-api

request the caniuse data to check browsers compatibilities
MIT License
356 stars 27 forks source link

Fix failing tests #69

Closed phil-r closed 6 years ago

MoOx commented 6 years ago

Master didn't fail when it was build (I know it's 10 month ago, but semver...?). Could you explain the motivation or this PR?

phil-r commented 6 years ago

Hi @MoOx , for me latest master fails with 

TypeError: Cannot read property 'lastVersions' of undefined

Also I can't find such api(browserslist.queries.lastVersions.select(1)) in browserslist

phil-r commented 6 years ago

@MoOx Here is the change that removed queries from browserslist object: https://github.com/ai/browserslist/commit/640b62fa83a20897cae75298a9f2715642531623#diff-168726dbe96b3ce427e7fedce31bb0bcL465

MoOx commented 6 years ago

Can you please bump browserlist version to make this PR complete? Thanks!

phil-r commented 6 years ago

@MoOx done 😉

Nyalab commented 6 years ago

this was fixed by #71, thanks for your time though